Adds interface type to ROS2 message type name #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
added
in progress
jacobperron
approved these changes
May 8, 2019
dirk-thomas
approved these changes
May 8, 2019
|
Amazing, got non reproducible test failures -.- |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Force pushed to rebase to latest master... |
dirk-thomas
force-pushed
the
hidmic/fix-ros1-bridge
branch
from
2b5b0fa
to
435a954
Compare
|
Update: there are actually more tests failing - across all rmw impl. |
|
Merging this in order to release a first version into Dashing |
Topic bridging tests are OK but service bridging ones I was unable to reproduce, and that was happening before the rebase :( |
dhananjaysathe
pushed a commit
to rapyuta-robotics/ros1_bridge
that referenced
this pull request
Aug 22, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/build_farmer#192. This pull request fixes ros1 bridge mapping factory template to take into account the interface type in the message type name.
Another one to be added to the list in ros2/ros2#677.